Revert invalid with collection syntax#3365
Closed
groman92 wants to merge 27 commits into
Closed
Conversation
Scrapers and AI crawlers reading /reference pages hit a wall of navigation HTML before reaching the article. Put <main> first in DOM order across all three layouts while preserving the visual layout via CSS Grid order utilities. Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>
…da (#3309) * Add tighter and explicit timeout to S3 Client acquisition * Add intermediary logs
When `pivot.products` is configured with multiple products but a PR carries no matching product label (and no `products.default` is set), `changelog evaluate-pr` would still report `proceed`. The downstream `changelog add` step then failed with "At least one product is required", which is a workflow-level hard error and skips the helpful PR comment that surfaces the missing labels. Treat this case the same as a missing type label: return `NoLabel` and emit the product-label-table so the existing comment-failure path posts an actionable hint to the contributor. When `pivot.products` defines only one distinct product, assign it implicitly — no point requiring a redundant label when there is only one possible answer. Co-authored-by: Cursor <cursoragent@cursor.com>
…Documentation.Site in the tailwindcss group across 1 directory (#3340) Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: dependabot[bot] <support@github.com>
…on.Site in the eui group across 1 directory (#3339) Signed-off-by: dependabot[bot] <support@github.com>
…ation.Site (#3341) Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: dependabot[bot] <support@github.com>
* Fix ShouldContainHtml comparing actual HTML to itself expectedCompare was built from `actual` instead of `expected`, causing the assertion to always pass regardless of whether the expected fragment was present in the actual output. Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com> * Fix inline image renderer emitting alt text as title unconditionally The renderer was always writing title="<alt>" for every image, ignoring the actual title parsed from the markdown title syntax. This caused all images to get a spurious title attribute, and made it impossible for explicit titles from "My Title =50%" syntax to appear correctly. Use link.Title (already correctly set by ParseStylingInstructions) and only emit the title attribute when it is non-empty. Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com> * Align C# inline image tests with authoring test ground truth The F# authoring tests (the ground truth) document that inline images always use alt text as the title attribute — even when an explicit title is supplied in the markdown title syntax. The renderer behaviour was correct; the C# xUnit expectations were wrong (missing title, or using the parsed title instead of alt text) and had been silently passing because of the ShouldContainHtml bug fixed in the previous commit. Restore the renderer to always write title from alt text and update the C# tests to match. Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
* Merge Elastic.Documentation.Api.* into single project Three projects (Api.Core, Api.Infrastructure, Api.App) collapsed into Elastic.Documentation.Api. Mcp.Remote no longer references any Api.* project — its only deps are ServiceDefaults, services/Search, and services/Assembler. Key moves: - EuidSpanProcessor + EuidLogProcessor → ServiceDefaults (shared) - AddEuidEnrichment helper added to ServiceDefaults - Search gateway interfaces (IFullSearchGateway, INavigationSearchGateway, IChangesGateway) → services/Elastic.Documentation.Search - McpToolSourceName constant inlined into Mcp.Remote Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com> * Fix C# import ordering and name simplification after Api merge Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com> * Fix Dockerfile publish RID to use TARGETARCH/TARGETOS instead of linux-x64 Enables arm64 image builds to publish and copy the correct architecture artifact rather than always using the amd64 binary. Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com> * Address PR review: OTel source registration, assembly version, env var key - Register McpTools ActivitySource in Mcp.Remote TracerProvider so MCP spans are captured - Use GetEntryAssembly() over GetCallingAssembly() for service.version so the host service's version is reported rather than ServiceDefaults - OtlpProxyOptions now checks OTEL_EXPORTER_OTLP_ENDPOINT first then OTLP_PROXY_ENDPOINT as backward-compatible fallback, matching the documented priority order Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com> * Fix import ordering in Mcp.Remote Program.cs Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com> * [2/5] VSA: Collapse Gateway+Usecase into *Service per feature (#3335) Co-authored-by: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
#3318) Adds a new :deployment: option to the {settings} directive that hides settings not available for the specified deployment type (ech, ece, eck, self). Settings with applies_to metadata that lack an explicit entry for the requested deployment are treated as unavailable. Settings without any applies_to metadata are always shown. Updates docs/syntax/automated_settings.md to document the new option and adds filtered examples to the Kibana settings test page. Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
* Initial plan * fix: render markdown in magic callouts Agent-Logs-Url: https://github.com/elastic/docs-builder/sessions/d3957e8a-7eab-4572-9244-4e24fa63a74e Co-authored-by: leemthompo <32779855+leemthompo@users.noreply.github.com> * test: align magic callout regression naming Agent-Logs-Url: https://github.com/elastic/docs-builder/sessions/d3957e8a-7eab-4572-9244-4e24fa63a74e Co-authored-by: leemthompo <32779855+leemthompo@users.noreply.github.com> * fix: import markdig for magic callout rendering Agent-Logs-Url: https://github.com/elastic/docs-builder/sessions/00950126-9a51-427f-9b93-9d838ae7df13 Co-authored-by: leemthompo <32779855+leemthompo@users.noreply.github.com> * test: fix magic callout link regression fixture Agent-Logs-Url: https://github.com/elastic/docs-builder/sessions/3df80900-27a1-4d02-b422-7c98e5832c2d Co-authored-by: leemthompo <32779855+leemthompo@users.noreply.github.com> * docs: update code callouts section for clarity and inline formatting Reorder automatic callouts before explicit, add decision guidance, and document inline Markdown support in callout text. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * docs: don't make people read raw regex Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * docs: expand callout examples and note link limitation Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * docs: fold admonitions into intro prose per review Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: leemthompo <32779855+leemthompo@users.noreply.github.com> Co-authored-by: Liam Thompson <leemthompo@gmail.com> Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
_GroupLayout.cshtml was the one sidebar-grid layout missed by PR #3344. With _PagesNav now carrying md:order-1, the missing md:order-2 on <main> broke the visual layout of Codex group landing pages. Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>
Co-authored-by: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
groman92
had a problem deploying
to
integration-tests
GitHub Actions
Failure
|
Label error. Requires exactly 1 of: automation, breaking, bug, changelog:skip, chore, ci, dependencies, documentation, enhancement, feature, fix, redesign. Found: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit a75ed72 ("Fix new SDK Warnings") introduced [with(...)] as a syntax for creating collections with a custom comparer:
// What was introduced (not valid C#)
private readonly Dictionary<string, string> _substitutions = [with(StringComparer.OrdinalIgnoreCase)];
// What it should be
private readonly Dictionary<string, string> _substitutions = new(StringComparer.OrdinalIgnoreCase);
[with(...)] is not valid in any released C# version, including the C# 14 preview shipping with .NET 10. Inside a collection expression [...], with is treated as an identifier name — not a keyword — causing CS0103: The name 'with' does not exist in the current context. This broke the build for anyone pulling main after that commit.